fix: moved inline inputs styles to component's less file#11427
Merged
mistercrunch merged 1 commit intoapache:masterfrom Oct 27, 2020
Merged
fix: moved inline inputs styles to component's less file#11427mistercrunch merged 1 commit intoapache:masterfrom
mistercrunch merged 1 commit intoapache:masterfrom
Conversation
mistercrunch
approved these changes
Oct 27, 2020
Member
mistercrunch
left a comment
mistercrunch
left a comment
There was a problem hiding this comment.
LGTM as a quick fix, this whole component is on the roadmap for a bigger rehaul, much of it likely to be re-written, so this is a good band aid for now.
Member
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
This was referenced Nov 26, 2023
This was referenced Dec 14, 2023
This was referenced Dec 20, 2023
mistercrunch
added
🏷️ bot
This was referenced May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Time range wasn't rendering properly because of lack of styles. Styles were moved to FilterBox's css and it should render everywhere in same way.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION